[usdMaya] Clearing out the prim writers before saving the stage. #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Filed as internal issue #147936. |
sunyab
requested changes
Aug 19, 2017
| @@ -348,11 +348,13 @@ void usdWriteJob::endJob() | |||
| // prim for the export... usdVariantRootPrimPath | |||
| mJobCtx.mStage->GetRootLayer()->SetDefaultPrim(defaultPrim); | |||
| } | |||
| // clear this so that no stage references are left around | |||
| // and running code in destructors | |||
| mJobCtx.mMayaPrimWriterList.clear(); | |||
There was a problem hiding this comment.
I think having an explicit hook would be preferred to doing stuff in a destructor here - I'd rather have an explicit call to some sort of "PostExport" callback (or virtual function on the MayaPrimWriter base class)
Signed-off-by: Pal Mezei <palm@lumapictures.com>
sirpalee
force-pushed
the
pr/clear_writers_before_save
branch
from
a13d3e5
to
ef86067
Compare
|
@sunyab sorry for the late reply, but I just got the PR updated. I added a separate postExport function that runs before saving the stage. |
pixar-oss
added a commit
that referenced
this pull request
Jan 29, 2018
[usdMaya] Clearing out the prim writers before saving the stage.
AdamFelt
pushed a commit
to autodesk-forks/USD
that referenced
this pull request
Apr 16, 2024
…/internal-only/feature/pipeline_adsk Re-Enable test TfSafeOutputFile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change is super simple here; we are clearing the prim writers before saving the stage. This change is useful when somebody wants to run cleanup code in a primWriter's destruction. Otherwise, there is no way to track down the last write to get the same effect.
For example, we have been using feature successfully with some of our writers to optimize animation data before saving the stage.